[PATCH] msscript.ocx: Supply a stub ServiceProvider to InvokeEx in run_procedure.
Jacek Caban
jacek at codeweavers.com
Wed Sep 9 12:49:55 CDT 2020
Hi Gabriel,
On 08.09.2020 17:00, Gabriel Ivăncescu wrote:
> + struct sp_caller *sp_caller = heap_alloc(sizeof(*sp_caller));
> +
> + if (sp_caller)
> + {
> + sp_caller->IServiceProvider_iface.lpVtbl = &sp_caller_vtbl;
> + sp_caller->ref = 1;
I must admit that tests show that this caller is weird, but in any case
do we need to create its new instance on each invocation? For your
current implementation, a static instance would be enough. If we need
something more, we could probably cache it in ScriptModule.
Thanks,
Jacek
More information about the wine-devel
mailing list