[PATCH] msscript.ocx: Supply a stub ServiceProvider to InvokeEx in run_procedure.
Gabriel Ivăncescu
gabrielopcode at gmail.com
Thu Sep 10 08:32:39 CDT 2020
On 09/09/2020 20:49, Jacek Caban wrote:
> Hi Gabriel,
>
> On 08.09.2020 17:00, Gabriel Ivăncescu wrote:
>> + struct sp_caller *sp_caller =
>> heap_alloc(sizeof(*sp_caller));
>> +
>> + if (sp_caller)
>> + {
>> + sp_caller->IServiceProvider_iface.lpVtbl =
>> &sp_caller_vtbl;
>> + sp_caller->ref = 1;
>
>
> I must admit that tests show that this caller is weird, but in any case
> do we need to create its new instance on each invocation? For your
> current implementation, a static instance would be enough. If we need
> something more, we could probably cache it in ScriptModule.
>
> Thanks,
> Jacek
Ah right. When I tested on Windows, it always gave a different address
with a refcount of 1 on each invocation, but it obviously doesn't matter
so I'll just go with the static instance and keep it as short as possible.
More information about the wine-devel
mailing list