[PATCH v4 7/7] wmphoto: Implement WmpDecoder using jxrlib.

[Rémi Bernon]

On 2020-09-23 21:27, Esme Povirk (they/them) wrote:
> -        todo_wine_if(test_image[i].expected.ImageFileFormat == D3DX10_IFF_WMP)
> +        todo_wine_if(test_image[i].expected.ImageFileFormat ==
> D3DX10_IFF_WMP && hr == E_FAIL) /* JPEG-XR support is optional */
> 
> We should remove the todo_wine. If something isn't working because of
> a missing dependency, it's not working as far as the tests are
> concerned.
> 

Alright, I thought tests should try to pass in all cases, (possibly with 
a skip message) even if an optional dependency is not available.

> I had a thought about multiple frames. Maybe we should just create the
> object in Initialize to get the number of frames, and make a new one
> for each frame. (But I don't think it's necessary to figure that out
> right now.)
> 

Do you mean the first frame? I guess it could be created on Initialize 
indeed, but then all the frames too. Doing it lazily when requested was 
mostly to make sure that we don't do unnecessary work when it's not 
going to be needed, but it probably doesn't matter too much.
-- 
Rémi Bernon <rbernon at codeweavers.com>