[PATCH] rtworkq/tests: Load CoGetApartmentType() dynamically.

Nikolay Sivov nsivov at codeweavers.com
Thu Apr 22 03:55:26 CDT 2021


On 4/21/21 9:18 PM, Francois Gouget wrote:
> The main goal is to get WineTest reports to state that the test was
> skipped because rtworkq.dll is missing rather than because of a
> possibly unrelated API.
>
> Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
> ---
> Restating differently, currently looking at a WineTest report (or
> test.winehq.org) I see that the test was skipped on Vista because
> of a missing API and I am left to guess whether rtworkq.dll was
> available at all.
>
> This patch takes out the guessing part even if nothing can be tested 
> (so far).

Is it possible to test for target dll first, before going through imports?

It did work somehow before, test page shows n/a for Vista/Win7,
mentioning rtworkq.dll correctly. CoGetApartmentType() exists on Win7+,
and rtworkq.dll on Win8+, so your change only applies to Vista?

So, if we have to, can we fix winetest logic instead, inferring "main"
module from test executable name as a first test, or some other way?



More information about the wine-devel mailing list