[PATCH] rtworkq/tests: Load CoGetApartmentType() dynamically.

Francois Gouget fgouget at codeweavers.com
Wed Apr 28 04:54:09 CDT 2021


On Thu, 22 Apr 2021, Nikolay Sivov wrote:
[...]
> Is it possible to test for target dll first, before going through imports?
> 
> It did work somehow before, test page shows n/a for Vista/Win7,
> mentioning rtworkq.dll correctly. CoGetApartmentType() exists on Win7+,
> and rtworkq.dll on Win8+, so your change only applies to Vista?
> 
> So, if we have to, can we fix winetest logic instead, inferring "main"
> module from test executable name as a first test, or some other way?

That's what WineTest used to do and it is very unreliable and caused 
many other problems:
https://bugs.winehq.org/show_bug.cgi?id=45032

Now (e618fb526d06) WineTest does not blindly trust the result from this 
test and instead runs xxx_test.exe --list and then checks the 
CreateProcess() error code to detect why the executable could not be 
run. That's how WineTest now knows that there is an entry point missing.

But whether CreateProcess() reports the missing dll or the missing API 
first is not up to us.

-- 
Francois Gouget <fgouget at codeweavers.com>



More information about the wine-devel mailing list