[PATCH 1/4] wininet/tests: Update InternetErrorDlg tests taking recent Windows 10 results as a base.
dmitry at baikal.ru
Thu Aug 26 14:33:51 CDT 2021
Thanks for the review.
Jacek Caban <jacek at codeweavers.com> wrote:
> > @@ -1583,7 +1586,7 @@ static void test_InternetErrorDlg(void)
> > expected = ERROR_INVALID_PARAMETER;
> > res = InternetErrorDlg(hwnd, NULL, i, FLAGS_ERROR_UI_FLAGS_NO_UI, NULL);
> > - todo_wine_if( test_flags & FLAG_TODO || i == ERROR_INTERNET_INCORRECT_PASSWORD)
> > + todo_wine_if ((test_flags & FLAG_TODO) || i == ERROR_INTERNET_INCORRECT_PASSWORD || i == ERROR_INTERNET_INSERT_CDROM || i == ERROR_INTERNET_CLIENT_AUTH_CERT_NEEDED)
> Is there a reason why you don't use FLAG_TODO for those? It may not
> match what you need for your new tests, but why are you changing half of
> its usage here?
Because using FLAG_TODO is fragile due to inconsistent behaviour, and it
fails in new or old tests. I tried different approaches in hope to make
it more clean and less controvercial regarding FLAG_TODO usage, but finally
decided to have it this way. I'm still open to suggestions though, however
I haven't found anything better while changing the tests to follow recent
More information about the wine-devel