[PATCH vkd3d 4/5] vkd3d-shader/hlsl: Merge the "type" and "base_type" rules.

Zebediah Figura (she/her) zfigura at codeweavers.com
Tue Aug 31 20:15:09 CDT 2021


On 8/31/21 6:31 PM, Matteo Bruni wrote:
> Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
> ---
> I guess the original choice was mostly a "defensive" one: it's
> generally better to start with a restrictive grammar and then remove
> constraints as necessary rather than the other way around.
> 

Sure. On the other hand, it's probably better to have less things result 
in a syntax error, so that you can emit more errors per run. But I don't 
mean to imply that the original code was unreasonable ;-)



More information about the wine-devel mailing list