[PATCH v12 6/7] mshtml: Set the builtin prop to NULL even when removeAttribute returns false in IE8 mode.

[Jacek Caban]

On 12/2/21 2:20 PM, Gabriel Ivăncescu wrote:
> On 01/12/2021 21:24, Jacek Caban wrote:
>> Hi Gabriel,
>>
>> On 12/1/21 2:41 PM, Gabriel Ivăncescu wrote:
>>> + if(dispex_compat_mode(This) >= COMPAT_MODE_IE8) {
>>> +                    V_VT(&var) = VT_NULL;
>>> +                    builtin_propput(This, func, &dp, NULL);
>>> +                }
>>
>>
>> That doesn't seem universally right, see the attached test for an 
>> example.
>>
>>
>> Thanks,
>>
>> Jacek
>>
>
> Are you sure this is related to this patch? I did some digging but it 
> seems to be a completely different issue to me. This patch is about 
> removeAttribute returning false and setting to NULL, which happens 
> with event handlers. 


Yes, the existing code is already wrong, we probably shouldn't blindly 
try to set value to VT_EMPTY in the first place. Trying to set the 
property to another value (of type that doesn't make sense unless you 
assume that those are event handlers) based on a previous error that we 
know nothing about (it could be OOM?) is making it even worse. Is there 
another reason for this patch than a todo_wine in tests?


Thanks,

Jacek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20211202/dacfbed6/attachment.htm>