[PATCH vkd3d v3 10/12] vkd3d-shader/hlsl: Include new texture dimension types in sampler_dim_count().
Francisco Casas
fcasas at codeweavers.com
Mon Dec 20 12:10:57 CST 2021
December 17, 2021 8:35 PM, "Zebediah Figura (she/her)" <zfigura at codeweavers.com> wrote:
> On 12/17/21 13:12, Francisco Casas wrote:
>
>> This function is also moved from hlsl.y to hlsl.h, since it can be useful in
>> other files.
>
> I would prefer to do that only in the patch where it's actually used.
Okay.
> Is there a reason to make it a static inline function, instead of just linking to it?
Since this function is small and so closely related to enum hlsl_sampler_dim,
I had the feeling that it would be good to keep it close to it.
But I can move it to hlsl.c.
More information about the wine-devel
mailing list