[PATCH] server: Accept DBG_EXCEPTION_HANDLED parameter in continue_debug_event.

[Francois Gouget]

On Wed, 6 Jan 2021, Rémi Bernon wrote:

> On 1/6/21 3:55 PM, Marvin wrote:
> > Hi,
> > 
> > While running your changed tests, I think I found new failures.
> > Being a bot and all I'm not very good at pattern recognition, so I might be
> > wrong, but could you please double-check?
> > 
> > Full results can be found at:
> > https://testbot.winehq.org/JobDetails.pl?Key=83809
[...]
> I think w10pro64 has some issues, or something is already wrong with this
> specific test on this specific windows version. For instance, the same test
> with a no-op patch gives the same kind of failures here:
> 
> https://testbot.winehq.org/JobDetails.pl?Key=83808#k305

Both indicate a Windows crash. The telltale signs:

* The "TestAgentd.exe was restarted. Did Windows reboot?" dialog in
  the final screenshot. [1]

* The "The test VM has crashed, rebooted or lost connectivity" message 
  in the testbot log.

This reminds me of the previous issue caused by the 4.19.0-8 kernel [2]. 
It's the same KERNEL_SECURITY_CHECK_FAILURE BSOD. However vm4 is running 
the 4.19.0-13 kernel which should be exempt from this issue.

The patch I applied to avoid the crashes before [3] does not prevent 
crashes this time around but changes the BSOD to 
SYSTEM_SERVICE_EXCEPTION (which does not really help me).


I've tried to identify a commit or event that could explain why this 
issue is back and built the following timeline:

(Run day; Commit day; Commit id; Result/Subject; Job id)
06 06 4ac05a : WineTest crash in ntdll:exception (83814)
05 05 c0ca69 : WineTest crash in ntdll:exception (83791)
04 04 221fdb : WineTest crash in ntdll:exception (83774)
02 02 6.0-rc5: WineTest crash in ntdll:exception (83753)
30 30 784cb20: WineTest crash in ntdll:exception (83733)
29 29 c20d49 : WineTest crash in ntdll:exception (83724)
28 28 ff09f1 : WineTest crash in ntdll:exception (83701)
   28 c414f2 : ntdll: Accept DBG_EXCEPTION_HANDLED parameter...
   27 93c485 : ntdll: Clear AC flag in align check test.
28 26 6.0-rc4: WineTest crash in ntdll:exception (83681)
28           : TestBot Engine rescued from the 99 errors of hell
27           : Network is back (18:00)

24           : Network outage (18:00)
23 23 9d7a71 : WineTest no crash (83664)
23           : Power outage (16:00)
22 22 e27a95 : WineTest no crash (83648)
   22 175a36 : ntdll: Always copy context...
21 21 3d2b42 : WineTest truncated at comctl32:datetime (83627)
18 18 6.0-rc3: WineTest no crash (83589)
   17 71a433 : ntdll: Save unwind information...
17 17 0aa6f8 : WineTest no crash (83554)
16 16 ef876f : WineTest no crash (83529)
15 15 79e267 : WineTest no crash (83495)

15           : Reboot vm4 to the 4.19.0-13 kernel
14 14 04ddab : WineTest crash in ntdll:exception (83424)
14           : Rebuilt vm4 from backup (4.19.0-8, oops!), restored VMs

11 11 6.0-rc2: WineTest no crash (83364)
10 10 be4592 : WineTest no crash (83328)
09 09 76c9db : WineTest no crash (83306)
08 08 310019 : WineTest no crash (83240)
   07 183a8c : ntdll: ntdll: Restore non-volatile registers...


So it looks like things started going south again after the Christmas 
power / network outage. Yet I did not change anything in the VM 
configuration then.

So in case the power outage caused some corruption in the w10pro64 qcow2 
[4] I restored the VM from backup but it still crashes the same way. 
Then I rebooted the host and it's still bad:

https://testbot.winehq.org/JobDetails.pl?Key=83847
https://testbot.winehq.org/JobDetails.pl?Key=83852

So I don't know what's up.


[1] The non-English locale screenshots are missing the "Windows 
    rebooted" dialog which points to a bug in the LibvirtTool code 
    creating these live snapshots.

[2] https://www.winehq.org/pipermail/wine-devel/2020-December/178570.html
    https://www.winehq.org/pipermail/wine-devel/2020-December/178431.html

[3] https://www.winehq.org/pipermail/wine-devel/2020-December/178398.html

[4] According to the timeline there was still one good run after the 
    power outage but with the way Munin and the TestBot handle timezones 
    I may have gotten the order wrong.

-- 
Francois Gouget <fgouget at codeweavers.com>