[PATCH 13/18] ntdll: Use syscall frame for YMM context in x86_64 NtGetContextThread.

Jacek Caban jacek at codeweavers.com
Fri Jan 22 12:03:54 CST 2021


On 22.01.2021 18:44, Paul Gofman wrote:
>> xsave is part of SSE2, not AVX, and it should ignore unsupported
>> requested features, so the patch should be fine as is on hardware
>> without AVX. xsave needs, however, to be enabled by OS, so we may need
>> a feature check if we want to support OSes without xsave enabled.
>>
> There was a real bug with that:
> https://bugs.winehq.org/show_bug.cgi?id=50271.


Looking at the bug report, I think it was about missing AVX support, not 
missing XSAVE support, so it should be fine with my patches.


I would need to do testing to be sure, but I noticed that our feature 
detection looks suspicious. I would expect that we should do something 
like the attached patch (but if it's right, it would also need fixes in 
ntdll).


Jacek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20210122/af94c952/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xstate.diff
Type: text/x-patch
Size: 947 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20210122/af94c952/attachment.bin>


More information about the wine-devel mailing list