[PATCH] wined3d: Select physical device with highest apiVersion.

Jan Sikorski jsikorski at codeweavers.com
Mon Jan 25 10:24:33 CST 2021


On 1/25/21 5:14 PM, Henri Verbeet wrote:
> On Mon, 25 Jan 2021 at 17:03, Jan Sikorski <jsikorski at codeweavers.com> wrote:
>> ---
>>   dlls/wined3d/adapter_vk.c | 19 +++++++++++++++----
>>   1 file changed, 15 insertions(+), 4 deletions(-)
>>
> I'm not sure that's a good idea, the device with the highest API
> version may very well be a software renderer.

Right, good point. The first device could be as well? (not sure if 
there's some implied ordering)

> It should also ultimately be unnecessary. On systems with multiple
> GPUs, we should simply create a wined3d adapter for each device. If
> for some reason we'd like to change the order in which those are
> enumerated, either winex11/winemac or the native Vulkan loader would
> seem like a better place.

That was meant as a slight improvement over just picking the first one - 
apparently even a single GPU can present multiple physical devices with 
different capabilities. Changing the order seems even more hacky. Either 
way it's a workaround, not intended as a final solution.

- Janek



More information about the wine-devel mailing list