[PATCH 4/4] wined3d: Move state handling to wined3d_cs_emit_set_shader().

Zebediah Figura (she/her) zfigura at codeweavers.com
Tue Mar 2 11:07:08 CST 2021


On 3/2/21 10:59 AM, Henri Verbeet wrote:
> On Tue, 2 Mar 2021 at 17:36, Zebediah Figura (she/her)
> <zfigura at codeweavers.com> wrote:
>> Essentially, my plan *was* to export wined3d_cs_emit_set_shader()
>> directly [perhaps with some terminology changed, but the same
>> arguments]. I guess the only reason not to do that now is
>> wined3d_device_set_state().
>>
> An argument could perhaps be made for e.g. a wined3d_cs_set_shader(),
> but ultimately the existence of struct wined3d_cs seems like a wined3d
> implementation detail from the point of view of e.g. d3d11.
> 

Sure, but it's not clear to me that's a sign that anything other than
the terminology is bad (which was always going to be true). The
wined3d_cs_* functions and wined3d_cs could be easily renamed to
something else.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20210302/a3dc23ed/attachment.sig>


More information about the wine-devel mailing list