[PATCH 3/7] reg: Free key_name memory before returning (Coverity)

Hugh McMaster hugh.mcmaster at outlook.com
Mon Mar 29 07:24:33 CDT 2021


Signed-off-by: Hugh McMaster <hugh.mcmaster at outlook.com>
---
 programs/reg/query.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/programs/reg/query.c b/programs/reg/query.c
index c8277cd7114..fb9305dea35 100644
--- a/programs/reg/query.c
+++ b/programs/reg/query.c
@@ -331,7 +331,7 @@ int reg_query(int argc, WCHAR *argvW[])
     HKEY root;
     WCHAR *path, *key_name, *value_name = NULL;
     BOOL value_empty = FALSE, recurse = FALSE;
-    int i;
+    int i, ret;
 
     if (!parse_registry_key(argvW[2], &root, &path, &key_name))
         return 1;
@@ -370,9 +370,12 @@ int reg_query(int argc, WCHAR *argvW[])
     if (value_name && value_empty)
         goto invalid;
 
-    return run_query(root, path, key_name, value_name, value_empty, recurse);
+    ret = run_query(root, path, key_name, value_name, value_empty, recurse);
+    free(key_name);
+    return ret;
 
 invalid:
+    free(key_name);
     output_message(STRING_INVALID_CMDLINE);
     return 1;
 }
-- 
2.31.0




More information about the wine-devel mailing list