[PATCH 3/7] reg: Free key_name memory before returning (Coverity)
Alexandre Julliard
julliard at winehq.org
Mon Mar 29 09:53:03 CDT 2021
Hugh McMaster <hugh.mcmaster at outlook.com> writes:
> @@ -370,9 +370,12 @@ int reg_query(int argc, WCHAR *argvW[])
> if (value_name && value_empty)
> goto invalid;
>
> - return run_query(root, path, key_name, value_name, value_empty, recurse);
> + ret = run_query(root, path, key_name, value_name, value_empty, recurse);
> + free(key_name);
> + return ret;
>
> invalid:
> + free(key_name);
> output_message(STRING_INVALID_CMDLINE);
> return 1;
> }
Freeing memory before process exit is not useful, so it's not worth
making the code more complicated for this.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list