[PATCH v2 3/5] mshtml: Don't release location when releasing the window.

Gabriel Ivăncescu gabrielopcode at gmail.com
Tue Nov 2 13:07:12 CDT 2021


We don't hold a refcount to the location, but only a weak ref (as tests show).

Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
---
 dlls/mshtml/htmlwindow.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c
index 0b25e71..4e5b036 100644
--- a/dlls/mshtml/htmlwindow.c
+++ b/dlls/mshtml/htmlwindow.c
@@ -269,10 +269,8 @@ static void release_inner_window(HTMLInnerWindow *This)
         heap_free(This->global_props[i].name);
     heap_free(This->global_props);
 
-    if(This->location) {
+    if(This->location)
         This->location->window = NULL;
-        IHTMLLocation_Release(&This->location->IHTMLLocation_iface);
-    }
 
     if(This->image_factory) {
         This->image_factory->window = NULL;
-- 
2.31.1




More information about the wine-devel mailing list