[PATCH 2/2] user32: Add a new __wine_set_desktop callback.

Rémi Bernon rbernon at codeweavers.com
Fri Nov 19 06:46:57 CST 2021


On 11/19/21 13:17, Jacek Caban wrote:
> Hi Rémi,
> 
> On 11/19/21 12:23 PM, Rémi Bernon wrote:
>> This makes register_builtin_classes to not be called anymore in the
>> desktop process, and IME window creation to fail when the systray window
>> is created.
> 
> 
> Thanks for looking at it. I was planning to send the attached patch 
> after a bit more testing, I'd expect it to solve the problem that you 
> noticed.
> 
> 
> Jacek

Yes, looks like it works as well, but I'm a bit afraid that doing the 
builtin class registration in GetDesktopWindow is a bet that it'll be 
called by the desktop process and called soon enough, which I'm not sure 
we can have any guarantee about.

I suppose that the wine_create_desktop call will have to be changed at 
some point anyway, so it doesn't look completely wrong to use it to 
notify of desktop initialization completion. This can probably be done 
later too.

The change to CreateCursor then makes calling wait_graphics_driver_ready 
also unnecessary, but there too I'm a bit afraid that we could get some 
convoluted call chain to it somehow too, and calling it explicitly when 
desktop is initialized also seems safer.

Cheers,
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list