[PATCH 2/2] user32: Add a new __wine_set_desktop callback.

Jacek Caban jacek at codeweavers.com
Fri Nov 19 06:55:01 CST 2021


On 11/19/21 1:46 PM, Rémi Bernon wrote:
> On 11/19/21 13:17, Jacek Caban wrote:
>> Hi Rémi,
>>
>> On 11/19/21 12:23 PM, Rémi Bernon wrote:
>>> This makes register_builtin_classes to not be called anymore in the
>>> desktop process, and IME window creation to fail when the systray 
>>> window
>>> is created.
>>
>>
>> Thanks for looking at it. I was planning to send the attached patch 
>> after a bit more testing, I'd expect it to solve the problem that you 
>> noticed.
>>
>>
>> Jacek
>
> Yes, looks like it works as well, but I'm a bit afraid that doing the 
> builtin class registration in GetDesktopWindow is a bet that it'll be 
> called by the desktop process and called soon enough, which I'm not 
> sure we can have any guarantee about. 


I sent a bit different version of the patch that adds another call that 
will make sure that it's called soon enough in explorer process and 
removed the call from load_driver() entirely. Note that there are other, 
not desktop related, cases that we should handle as well. For example 
wineandroid.drv is also a sounds driver, so it may be loaded without 
user32/win32u involvement.


Thanks,

Jacek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20211119/4fb0ef08/attachment.htm>


More information about the wine-devel mailing list