[PATCH 3/6] wined3d: Allow OpenGL pixel pack buffer objects to be suballocated from a larger buffer.

[Zebediah Figura]

On 11/22/21 4:31 AM, Henri Verbeet wrote:
> On Sat, 20 Nov 2021 at 00:41, Zebediah Figura <zfigura at codeweavers.com> wrote:
>> @@ -484,7 +487,7 @@ void texture2d_read_from_framebuffer(struct wined3d_texture *texture, unsigned i
>>       width = wined3d_texture_get_level_width(texture, level);
>>       height = wined3d_texture_get_level_height(texture, level);
>>       gl_info->gl_ops.gl.p_glReadPixels(0, 0, width, height,
>> -            format_gl->format, format_gl->type, data.addr);
>> +            format_gl->format, format_gl->type, offset);
>>       checkGLcall("glReadPixels");
>>
>>       /* Reset previous pixel store pack state */
> 
> Should the "if (!src_is_upside_down)" block further down also be adjusted?
> 

Indeed. Actually it looks like it's also missing an adjustment by 
data.addr, which is probably why I didn't catch it in the first place.