[PATCH 3/4] wined3d: Always set GL_PIXEL_UNPACK_BINDING in wined3d_texture_gl_allocate_mutable_storage().

Henri Verbeet hverbeet at gmail.com
Tue Nov 30 11:10:53 CST 2021


On Tue, 30 Nov 2021 at 01:29, Zebediah Figura <zfigura at codeweavers.com> wrote:
> @@ -947,6 +947,9 @@ static void wined3d_texture_gl_allocate_mutable_storage(struct wined3d_texture_g
>              TRACE("texture_gl %p, layer %u, level %u, target %#x, width %u, height %u.\n",
>                      texture_gl, layer, level, target, width, height);
>
> +            GL_EXTCALL(glBindBuffer(GL_PIXEL_UNPACK_BUFFER, 0));
> +            checkGLcall("glBindBuffer");
> +
Sure, but I don't think this needs to be inside the loop.

Also, "GL_PIXEL_UNPACK_BINDING" isn't a thing. There's
GL_PIXEL_UNPACK_BUFFER_BINDING, but in that case it would probably
have been best to use that in patches 1/4 and 2/4 as well.



More information about the wine-devel mailing list