[PATCH 2/4] nsiproxy: Use str(n)casecmp() instead of _strnicmp().

Jacek Caban jacek at codeweavers.com
Fri Oct 1 08:01:58 CDT 2021


Hi Huw,

On 10/1/21 2:04 PM, Huw Davies wrote:
> Signed-off-by: Huw Davies<huw at codeweavers.com>
> ---
>   dlls/nsiproxy.sys/ip.c   | 22 +++++++++++-----------
>   dlls/nsiproxy.sys/ndis.c |  2 +-
>   dlls/nsiproxy.sys/tcp.c  |  4 ++--
>   dlls/nsiproxy.sys/udp.c  |  6 +++---
>   4 files changed, 17 insertions(+), 17 deletions(-)


There was a reason we avoided those in pre-PE code. Piotr should know 
more details, but I think it unreliable for Turkish locale (IIRC 
something about handling uppercased 'i'). It looks like a local helper 
that would just handle case sensitivity for ASCII subset would be enough 
here.


Thanks,

Jacek




More information about the wine-devel mailing list