[PATCH 4/4] Reindent in order to avoid compiler's warning (GCC11)

Rémi Bernon rbernon at codeweavers.com
Sun Oct 3 05:56:34 CDT 2021


On 10/3/21 3:21 AM, Emil Velikov wrote:
> Hi Eric
> 
> Hats off for taking this mundane, yet important endeavour.
> 
> On Sat, 2 Oct 2021 at 13:06, Eric Pouech <eric.pouech at gmail.com> wrote:
> 
>> If this patch is accepted, I volunteer to keep pushing the remaining
>> changes. With the following rules:
>> - one patch per file
> 
> Perhaps make that one patch per dll? Some dlls have 10+ C files in their tests/
> Just a small comment from an outsider.
> 
> HTH
> -Emil
> 

FWIW Alexandre sometimes edits the titles when committing the patches, 
but if you intend so send a lot of patches I'm sure it'll be appreciated 
to make them match the usual pattern already.

This means a "<module>: " prefix, or "<module>/tests: " if test files 
only are changed (with some possible variations in <module> to indicate 
some area of the module, usually done like "<module>/<area>: "), 
followed by the title sentence with an upper case first letter, and a 
final dot / period.

Then, although it probably matters a bit less, the commit messages 
should also probably use capitalized sentences.

You can also add the v2: / v3:... / other contextual patch comments 
below the git send-email "---" marker (and above the first "diff"), so 
they won't be included in the commit message.

Cheers,
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list