[PATCH 3/3] hidclass.sys: Drop reports when length doesn't match their declaration.
Rémi Bernon
rbernon at codeweavers.com
Mon Oct 4 03:18:14 CDT 2021
Based on a patch from Ivo Ivanov <logos128 at gmail.com>.
Instead of using the descriptor input report length, which is the
maximum length of all input reports.
Tests show that the reports should be dropped, in non-polled mode, when
their length is invalid, but we were dropping too many of them.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51828
Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
---
dlls/hidclass.sys/device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c
index 785c45dce3a..ae8d80c2e95 100644
--- a/dlls/hidclass.sys/device.c
+++ b/dlls/hidclass.sys/device.c
@@ -349,7 +349,8 @@ static DWORD CALLBACK hid_device_thread(void *args)
packet->reportBuffer = buffer;
packet->reportBufferLen = io.Information;
- if (polled || io.Information == desc->InputLength)
+ report = find_report_with_type_and_id( ext, HidP_Input, buffer[0], FALSE );
+ if (polled || (report && report->InputLength == io.Information))
hid_device_queue_input( device, packet );
}
--
2.33.0
More information about the wine-devel
mailing list