[PATCH v3] gdi32: Create the registry keys recursively, if needed.

Gabriel Ivăncescu gabrielopcode at gmail.com
Mon Oct 4 08:16:47 CDT 2021


On 04/10/2021 09:39, Huw Davies wrote:
> On Sun, Oct 03, 2021 at 08:33:41AM -0500, Marvin wrote:
>> Hi,
>>
>> While running your changed tests, I think I found new failures.
>> Being a bot and all I'm not very good at pattern recognition, so I might be
>> wrong, but could you please double-check?
>>
>> Full results can be found at:
>> https://testbot.winehq.org/JobDetails.pl?Key=99265
>>
>> Your paranoid android.
>>
>>
>> === debiant2 (32 bit report) ===
>>
>> gdi32:
>> font.c:1234: Test failed: GetCharABCWidthsW should have failed
>> font.c:1681: Test failed: GetGlyphIndicesW should have returned a 001f not 0000
>> font.c:4387: Test failed: info[0] = 3 for the system font
>> font.c:5033: Test failed: Unexpected first glyph L":"
>> font.c:5060: Test failed: Unexpected first glyph L":"
>> font.c:7484: Test failed: expected 0, got -1
>> font.c:7485: Test failed: expected 0, got -6
>> metafile.c:5106: Test failed: expected 0, got 150
>> metafile.c:5180: Test failed: expected 0, got 150
> 
> These do indeed appear to be new failures.
> 
> Huw.
> 

Well, I get those tests even without this patch applied. I don't 
actually see how it *could* influence the tests anyway, because it first 
tries to open the key directly (like the helper in kernelbase) so as 
long as the key exists, the behavior should be identical to before.

Maybe the testbot created new prefixes and the tests were simply broken 
before and not tested somehow? At least when creating a 32-bit prefix, 
my window decorator crashed without this patch.

Thanks,
Gabriel



More information about the wine-devel mailing list