[PATCH 6/7] mshtml: Allocate DISPIDs only for actual attributes in HTMLAttributeCollection.

[Jacek Caban]

On 10/1/21 3:12 PM, Gabriel Ivăncescu wrote:
> Signed-off-by: Gabriel Ivăncescu<gabrielopcode at gmail.com>
> ---
>
> Presently, even toString() is exposed as an attribute, because it's a
> builtin of the element, which makes no sense.


Unfortunately, it's more tricky than that. With that change, we'd expose 
too few attributes (instead of too many), which is likely to cause 
regressions. In general, attributes objects were not yet updated for 
compatibility modes and they are likely to require more drastic changes. 
I would expect attributes to be proper nodes in IE9+ mode (rather than 
node alike objects from previous versions), so we could probably make 
them a wrappers around nsIDOMAttr using HTMLDOMNode. Similarly, it would 
be interesting to try to use nsIDOMMozNamedAttrMap for 
HTMLAttributeCollection.


I'm not sure why it matters for toString, it seems like none of that 
should be required to get toString itself working.


Thanks,

Jacek