[PATCH 4/4] winegstreamer: Mark winegstreamer.so as NODELETE instead of pinning winegstreamer.dll.

Zebediah Figura (she/her) zfigura at codeweavers.com
Mon Oct 4 22:32:22 CDT 2021


On 10/4/21 20:57, Chip Davis wrote:
> October 4, 2021 7:21 PM, "Zebediah Figura" <zfigura at codeweavers.com> wrote:
> 
>> diff --git a/dlls/winegstreamer/Makefile.in b/dlls/winegstreamer/Makefile.in
>> index e35df3cf3f9..95c2d885482 100644
>> --- a/dlls/winegstreamer/Makefile.in
>> +++ b/dlls/winegstreamer/Makefile.in
>> @@ -3,7 +3,9 @@ UNIXLIB = winegstreamer.so
>>   IMPORTS   = strmbase strmiids uuid ole32 mfuuid
>>   DELAYIMPORTS = mfplat
>>   EXTRAINCL = $(GSTREAMER_CFLAGS)
>> -EXTRALIBS = $(GSTREAMER_LIBS) $(PTHREAD_LIBS)
>> +# GLib pins some of its own libraries, and breaks if libraries that import it
>> +# try to initialize themselves after being unloaded.
>> +EXTRALIBS = $(GSTREAMER_LIBS) $(PTHREAD_LIBS) -Wl,-z,nodelete
> 
> This needs a configure check--especially since it won't work on macOS.
> 

Of course it won't. Please ignore this patch, then.



More information about the wine-devel mailing list