[PATCH v2] makedep: Always define _NTSYSTEM_ for native Unix libraries.

Jacek Caban jacek at codeweavers.com
Tue Oct 5 09:10:44 CDT 2021


On 10/5/21 4:00 PM, Alexandre Julliard wrote:
> Huw Davies <huw at codeweavers.com> writes:
>
>> From: Jacek Caban <jacek at codeweavers.com>
>>
>> Signed-off-by: Jacek Caban <jacek at codeweavers.com>
>> Signed-off-by: Huw Davies <huw at codeweavers.com>
>> ---
>> Small fix to remove _NTSYSTEM_ from dlls/nsiproxy/icmp_echo.c that I added yesterday.
>>
>> dlls/nsiproxy.sys/icmp_echo.c | 2 --
>>   dlls/nsiproxy.sys/ip.c        | 2 --
>>   dlls/winepulse.drv/pulse.c    | 2 --
>>   tools/makedep.c               | 2 ++
>>   4 files changed, 2 insertions(+), 6 deletions(-)
> I'd suggest to use WINE_UNIX_LIB for this instead of adding more
> defines.


The drawback of WINE_UNIX_LIB is that it's also defined for Unix libs 
not using __wine_unix_call interface, so we will stop using 
DECLSPEC_HIDDEN for ntdll declarations there. It shouldn't cause 
problems, through. I will send a new version once I have it tested.


Thanks,

Jacek




More information about the wine-devel mailing list