Le 06/10/2021 à 16:01, David Kahurani a écrit :
> The if clause here does not make much sense and
> would probably get optimized out by a smart compiler
>
> Signed-off-by: David Kahurani<k.kahurani at gmail.com>
> ---
> dlls/ntdll/unix/system.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/dlls/ntdll/unix/system.c b/dlls/ntdll/unix/system.c
> index 82c9f0d..88050fb 100644
> --- a/dlls/ntdll/unix/system.c
> +++ b/dlls/ntdll/unix/system.c
> @@ -2399,7 +2399,6 @@ NTSTATUS WINAPI NtQuerySystemInformation( SYSTEM_INFORMATION_CLASS class,
> case SystemPerformanceInformation: /* 2 */
> {
> SYSTEM_PERFORMANCE_INFORMATION spi;
> - static BOOL fixme_written = FALSE;
>
> get_performance_info( &spi );
> len = sizeof(spi);
> @@ -2409,10 +2408,7 @@ NTSTATUS WINAPI NtQuerySystemInformation( SYSTEM_INFORMATION_CLASS class,
> else memcpy( info, &spi, len);
> }
> else ret = STATUS_INFO_LENGTH_MISMATCH;
> - if(!fixme_written) {
> - FIXME("info_class SYSTEM_PERFORMANCE_INFORMATION\n");
> - fixme_written = TRUE;
> - }
> + FIXME("info_class SYSTEM_PERFORMANCE_INFORMATION\n");
> break;
> }
>
storage of fixme_written is static... so the FIXME is only printed once
if that code is called several times
should be kept as it is
+A
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20211006/15c797ab/attachment-0001.htm>