[PATCH 4/7] iphlpapi: Implement IcmpSendEcho2Ex() using nsiproxy.

[Gabriel Ivăncescu]

On 06/10/2021 14:59, Huw Davies wrote:
> On Wed, Oct 06, 2021 at 02:52:33PM +0300, Gabriel Ivăncescu wrote:
>> I had some patches that implement the async requests for IcmpSendEcho2Ex,
>> but obviously now it's completely different so need a rewrite. My question
>> is if you had planned to look into implementing them as well, or should I
>> try to when I have the time?
> 
> I haven't any patches waiting, but it should be straight forward now
> since the request is already asynchronous.  Feel free to give it a go.
> 
> Looking briefly at your patches, I suggest you don't try to implement
> the "waiting for the request to finish in IcmpCloseHandle()" behaviour
> unless you have an app that actually needs that.
> 
> Huw.
> 

Ok, I updated them now and sent. I decided to keep the wait for requests 
to finish, but I moved them to a separate patch at the end of the series 
(so it can be easily discarded if you dislike it). However, I vastly 
simplified it to a simple polling loop, because it shouldn't be common 
anyway and this keeps it extremely simple.

However, on the off-chance that some app does rely on this, for example 
to free its buffers after it closes (when it gives up on the echo at 
all), it avoids a very painful debugging experience with corrupted 
memory contents and the like... so I honestly think it's worth it.

Thanks,
Gabriel