[PATCH] user32: Add an exception handler to GetWindowText.
Rémi Bernon
rbernon at codeweavers.com
Wed Oct 13 05:04:09 CDT 2021
On 10/13/21 11:58 AM, Dmitry Timoshkov wrote:
> Rémi Bernon <rbernon at codeweavers.com> wrote:
>
>> FWIW everything else in this test function (and as far as I could see
>> most user32, or at least recently added, code) uses space-in-paren
>> style, if you're fixing the spaces I think it should be the other way
>> around ;)
>
> Well, the intent was actually to fix the failure message. I've got an impression
> that having a space after the first parenthese while the closing one doesn't have
> it is a typo. If removing the first space is a problem, I can surely resend.
>
Imho inconsistent style makes code much more difficult to read, and I
think we should aim to make things more consistent, not less, -at least
on the module scope- and use opportunities like this to fix inconsistencies.
For some modules it's hard to tell, but doing it a local basis too is
better than nothing.
--
Rémi Bernon <rbernon at codeweavers.com>
More information about the wine-devel
mailing list