[PATCH] winex11.drv: Add video adapter description to the registry.

[Dmitry Timoshkov]

Paul Gofman <pgofman at codeweavers.com> wrote:

> On 10/13/21 14:32, Dmitry Timoshkov wrote:
> > Paul Gofman <pgofman at codeweavers.com> wrote:
> >
> >> On 10/13/21 13:57, Dmitry Timoshkov wrote:
> >>> +    if (RegSetValueExW(hkey, dac_typeW, 0, REG_SZ, (const BYTE *)ramdacW, (strlenW(ramdacW) + 1) * sizeof(WCHAR)))
> >>> +    size = 0x7fffffff; /* FIXME */
> >> We used to have all sort of issues in various games querying VRAM size
> >> through any sources the game is aware about and misbehaving due to
> >> assuming wrong VRAM size. Is it possible to get the real VRAM size at
> >> once? HardwareInformation.MemorySize seems to be capped at 0xfff00000
> >> here with 8GB card on Windows. But there is also .qwMemorySize which is
> >> QWORD and holds real VRAM size. I thing once filling the legacy one we'd
> >> better also fill the full value as well. I suppose we can add VRAM size
> >> to x11drv_gpu and fill that in when querying GPU info through Vulkan.
> >> That might be still not entirely trivial as there are multiple heaps
> >> reported by Vulkan. I guess we should enumerate heaps with
> >> MEMORY_HEAP_DEVICE_LOCAL_BIT flag and choose the largest size.
> > I haven't found a way to specify real card memory size from winex11.drv.
> > Is there one that I've missed?
> >
> I don't think we currently query VRAM suze anywhere in winex11.drv, no. 
> What I am suggesting is to add the vram_size field to struct x11drv_gpu 
> and fill that in xrandr.c:get_gpu_properties_from_vulkan() (even if 
> leaving the same fallback default value for a case when Vulkan is not 
> available; we currently rely on Vulkan for device info fill in 
> winex11.drv anyway). If you are not up for dealing with that, maybe we 
> can skip adding the memory size field for now and if the rest gets in I 
> wll try to deal with that after?

Sure, that's fine. I'll resend the patch without memory size part.

-- 
Dmitry.