[PATCH v2 6/7] win32u: Move NtUserCloseWindowStation from user32.

Jacek Caban jacek at codeweavers.com
Wed Oct 13 08:16:14 CDT 2021


On 10/12/21 11:29 PM, Zebediah Figura wrote:
> On 10/12/21 9:42 AM, Jacek Caban wrote:
>> Signed-off-by: Jacek Caban <jacek at codeweavers.com>
>> ---
>> v2: Fixed comment in the new user.c file. Thanks, Nikolay.
>>
>>    dlls/user32/message.c      |  2 +-
>>    dlls/user32/user32.spec    |  2 +-
>>    dlls/user32/user_private.h |  2 +-
>>    dlls/user32/winstation.c   | 16 --------------
>>    dlls/win32u/Makefile.in    |  1 +
>>    dlls/win32u/syscall.c      |  2 ++
>>    dlls/win32u/win32u.spec    |  2 +-
>>    dlls/win32u/winstation.c   | 45 
>> ++++++++++++++++++++++++++++++++++++++
>>    dlls/wow64win/Makefile.in  |  3 ++-
>>    dlls/wow64win/syscall.h    |  3 ++-
>>    dlls/wow64win/user.c       | 35 +++++++++++++++++++++++++++++
>>    include/Makefile.in        |  1 +
>>    include/ntuser.h           | 27 +++++++++++++++++++++++
>>    13 files changed, 119 insertions(+), 22 deletions(-)
>>    create mode 100644 dlls/win32u/winstation.c
>>    create mode 100644 dlls/wow64win/user.c
>>    create mode 100644 include/ntuser.h
>>
>>
>
> It occurs to me (and might already have occurred to you) that the 
> SetLastError() here will need some manner of translation for wow64; I 
> don't know if that needs to be done on the win32u or wow64win side.


Yes, I thought about it, but I didn't write the code yet. My plan was to 
change SetLastError() to modify both TEBs in Unix libs. The alternative 
would be syncing TEBs in wow64win thunks.


Jacek




More information about the wine-devel mailing list