[PATCH vkd3d 5/5] vkd3d-shader/hlsl: Generate synthetic temps for object uniforms as well.
Zebediah Figura
zfigura at codeweavers.com
Thu Oct 14 10:58:00 CDT 2021
On 10/14/21 3:47 AM, Matteo Bruni wrote:
> On Tue, Oct 12, 2021 at 4:59 AM Zebediah Figura <zfigura at codeweavers.com> wrote:
>>
>> These can be assigned to when compatibility mode is used.
>
> Yep, pretty annoying if you ask me...
>
>> Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
>> ---
>> libs/vkd3d-shader/hlsl_codegen.c | 31 +++++++++++--------------------
>> 1 file changed, 11 insertions(+), 20 deletions(-)
>
> I'm curious, will this (or, rather, texture loads) work even without
> some form of copy propagation?
Not as such, but I have a follow-up patch to skip generating synthetic
temps if they aren't *actually* assigned to (or, in the case of output
variables, read from).
But we should really implement copyprop anyway.
>
> FWIW, this patch breaks register allocation for textures. Basically,
> has_resource_access never gets set for the "actual" extern variables.
>
More information about the wine-devel
mailing list