[PATCH 01/21] include/wine: suppress subsequent FIXMEs into WARNINGs

Chip Davis cdavis at codeweavers.com
Fri Oct 15 17:55:04 CDT 2021


In the future, please don't send so many patches at once. It makes it hard to review.

October 15, 2021 10:36 AM, "David Kahurani" <k.kahurani at gmail.com> wrote:

> diff --git a/include/wine/debug.h b/include/wine/debug.h
> index 6aac7fe..63041b0 100644
> --- a/include/wine/debug.h
> +++ b/include/wine/debug.h
> @@ -134,10 +152,14 @@ struct __wine_debug_channel
>  
>  #else  /* !__GNUC__ && !__SUNPRO_C */
>  
> -#define __WINE_DPRINTF(dbcl,dbch) \
> +#define __WINE_DPRINTF(dbcl,dbc2,dbch) \
> +    static BOOL __wine_next_time_level;\
> +    const enum __wine_debug_class __dbcl = \
> +    __wine_next_time_level ? __WINE_DBCL##dbc2 : __WINE_DBCL##dbc1;\
>      (!__WINE_GET_DEBUGGING(dbcl,(dbch)) || \
> -     (wine_dbg_log(__WINE_DBCL##dbcl,(dbch),__FILE__,"%d: ",__LINE__) == -1)) ? \
> -     (void)0 : (void)wine_dbg_printf
> +     (wine_dbg_log(__dbcl,(dbch),__FILE__,"%d: ",__LINE__) == -1)) ? \
> +     (void)0 : (void)wine_dbg_printf \
> +     __wine_next_time_level = TRUE;

It looks like you mixed up __WINE_DPRINTF() and __WINE_DPRINTF_ONCE() in this branch of the conditional.

> 
> #define __WINE_PRINTF_ATTR(fmt, args)
> 


Chip



More information about the wine-devel mailing list