[PATCH 6/6] winefile: Set size before calling RegQueryValueExW().

Zhiyi Zhang zzhang at codeweavers.com
Tue Oct 19 21:07:14 CDT 2021


The value in size may be invalid if previous RegQueryValueExW() calls failed.

Signed-off-by: Zhiyi Zhang <zzhang at codeweavers.com>
---
 programs/winefile/winefile.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/programs/winefile/winefile.c b/programs/winefile/winefile.c
index fa78237cccf..8ad785b924a 100644
--- a/programs/winefile/winefile.c
+++ b/programs/winefile/winefile.c
@@ -1220,20 +1220,22 @@ static windowOptions load_registry_settings(void)
         RegOpenKeyExW( HKEY_CURRENT_USER, registry_key,
                        0, KEY_QUERY_VALUE, &hKey );
 
-	size = sizeof(DWORD);
-
+        size = sizeof(opts.start_x);
         if( RegQueryValueExW( hKey, reg_start_x, NULL, &type,
                               (LPBYTE) &opts.start_x, &size ) != ERROR_SUCCESS )
 		opts.start_x = CW_USEDEFAULT;
 
+        size = sizeof(opts.start_y);
         if( RegQueryValueExW( hKey, reg_start_y, NULL, &type,
                               (LPBYTE) &opts.start_y, &size ) != ERROR_SUCCESS )
 		opts.start_y = CW_USEDEFAULT;
 
+        size = sizeof(opts.width);
         if( RegQueryValueExW( hKey, reg_width, NULL, &type,
                               (LPBYTE) &opts.width, &size ) != ERROR_SUCCESS )
 		opts.width = CW_USEDEFAULT;
 
+        size = sizeof(opts.height);
         if( RegQueryValueExW( hKey, reg_height, NULL, &type,
                               (LPBYTE) &opts.height, &size ) != ERROR_SUCCESS )
 		opts.height = CW_USEDEFAULT;
-- 
2.32.0



More information about the wine-devel mailing list