[PATCH] msvcrt: support I width modifier in *scanf* family

Eric Pouech eric.pouech at orange.fr
Wed Oct 20 06:36:08 CDT 2021


Le 20/10/2021 à 11:57, Piotr Caban a écrit :
> On 10/19/21 8:26 PM, Eric Pouech wrote:
>>     How about moving the tests to ucrtbase so you don't have to handle
>>     "broken" case (otherwise it's probably better to skip the test on
>>     old msvcrt)?
>>
>>
>> Would moving to ucrtbase only test for latest versions (>= 140) ? > 
>> It seems to me that all of I I32 I64 should be supported at the same
>> time and they could be present since 90 (at least)
> Yes, moving to ucrtbase will test only _MSVCR_VER==140 case. But 
> msvcrt tests are only testing msvcrt.dll (_MSVCR_VER==0 case).
>
> I was thinking about moving the tests only (not guarding the 
> implementation with _MSVCR_VER check). I think the tests are cleaner 
> if you don't have to worry about broken case. 

ok, I'll resend with putting the tests in ucrtbase

A+




More information about the wine-devel mailing list