[PATCH v2] msxml3/tests: Test VBSAXXMLReader.

[Jefferson Carpenter]

On 10/20/2021 4:50 PM, Nikolay Sivov wrote:
> Could you explain how it's crashing? Maybe we could have more targeted
> test for this specific problem instead.
> 

The application is passing a null url into parseURL.  I did a bisect and 
found the commit where this broke (Wine used to null check the URL) but 
I've lost it.  I can recover that if it would be helpful.

It might be passing a null url due to another wine bug, I'm not sure, 
but null checking looks like it conforms with Windows behavior, at least 
for early versions of msxml.

 >
 > I still think there is no reason for it to change that much, it's still
 > ~1400 lines diff.

The reason for the large patch is that there's an existing parseURL 
test, but it's part of a much larger saxreader test, so I figured it 
would be better to test the whole interface than to start duplicating 
individual test cases for the VB saxreader.  To run the existing test 
cases on the VB saxreader it has to expose VB content handlers and a 
large patch is required to implement all of those.

I could certainly send a smaller patch that queries for IVBSAXXMLReader 
and runs parseURL on it, but it would be side by side with the 
ISAXXMLReader tests or in a different test function and maintained 
separately, instead of automatically running all test cases under both 
interfaces.

It's not that big of a difference imo, if having separate sets of test 
cases for the saxreader and the VB saxreader would be more in the style 
of the project I would be happy to do that.  That is, if the code should 
be "unrolled" in the test that's good to know.