[PATCH vkd3d v2 06/10] vkd3d-shader/hlsl: Allow more implicit conversions between matrices and vectors.

Matteo Bruni matteo.mystral at gmail.com
Thu Oct 21 09:19:29 CDT 2021


On Fri, Oct 15, 2021 at 10:47 PM Zebediah Figura (she/her)
<zfigura at codeweavers.com> wrote:
>
> Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
>
> ---
>
> Although with the comment that it'd be nice to see some specific tests
> for these. I manually verified that this logic holds for three of the
> four places where we currently use add_implicit_conversion (viz. return
> values, assignments, and constructors); it doesn't hold for the fourth
> (the argument to Load) but that's probably not worth fixing.

Right, that seems to be a quirk that we probably don't want to
replicate unless really necessary.

Also, yes, tests are always welcome.



More information about the wine-devel mailing list