[v2 PATCH 5/5] msxml3: Update error for missing closing quote.

Nikolay Sivov nsivov at codeweavers.com
Fri Oct 22 08:41:29 CDT 2021


From: Daniel Lehman <dlehman25 at gmail.com>

Signed-off-by: Daniel Lehman <dlehman25 at gmail.com>
Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---
 dlls/msxml3/pi.c           | 2 +-
 dlls/msxml3/tests/domdoc.c | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/dlls/msxml3/pi.c b/dlls/msxml3/pi.c
index 606a2381c1b..4c5c6b12c68 100644
--- a/dlls/msxml3/pi.c
+++ b/dlls/msxml3/pi.c
@@ -298,7 +298,7 @@ static HRESULT xml_get_value(xmlChar **p, xmlChar **value)
 
     v = *p;
     while (**p && **p != q) *p += 1;
-    if (!**p) return XML_E_EXPECTINGCLOSEQUOTE;
+    if (!**p) return XML_E_BADCHARINSTRING;
     len = *p - v;
     if (!len) return XML_E_MISSINGNAME;
     *p += 1;
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index dbd56e11f68..70e2da89a2f 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -8600,10 +8600,8 @@ static void test_createProcessingInstruction(void)
     hr = IXMLDOMDocument_createProcessingInstruction(doc, _bstr_("xml"), _bstr_("version=\"1.0\" encoding=UTF-8"), &pi);
     ok(hr == XML_E_MISSINGQUOTE, "got 0x%08x\n", hr);
     hr = IXMLDOMDocument_createProcessingInstruction(doc, _bstr_("xml"), _bstr_("version=\"1.0\" encoding='UTF-8\""), &pi);
-todo_wine
     ok(hr == XML_E_BADCHARINSTRING, "got 0x%08x\n", hr);
     hr = IXMLDOMDocument_createProcessingInstruction(doc, _bstr_("xml"), _bstr_("version=\"1.0\" encoding=\"UTF-8"), &pi);
-todo_wine
     ok(hr == XML_E_BADCHARINSTRING, "got 0x%08x\n", hr);
     pi = NULL;
     hr = IXMLDOMDocument_createProcessingInstruction(doc, _bstr_("xml"), _bstr_("version=\"1.0\" encoding='UTF-8'"), &pi);
-- 
2.33.0




More information about the wine-devel mailing list