[PATCH 3/3] winegstreamer: Use videobox to align and padd NV12 video buffers.

Zebediah Figura (she/her) zfigura at codeweavers.com
Wed Oct 27 15:22:40 CDT 2021


On 10/27/21 10:04, Rémi Bernon wrote:
> Native MF aligns the NV12 planes on 16 pixels, and Greedfall expects it.
> 
> Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
> ---
>   dlls/winegstreamer/wg_parser.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 

This leaves me with a lot of questions, not least of which is "can we 
have tests for this"? Others are:

* This will change the actual height of the image, not just its layout. 
Is that really correct?

* Is it really correct to change the height and not the width?

* Is it really correct to change the reported dimensions in all 
circumstances? E.g. for all formats? I'm already pretty sure that it's 
wrong for DirectShow...



More information about the wine-devel mailing list