[PATCH 1/2] winegstreamer: Support block_alignment attribute mapping.

[Rémi Bernon]

On 10/27/21 10:30 PM, Zebediah Figura (she/her) wrote:
> On 10/27/21 10:25, Rémi Bernon wrote:
>> Planet Coaster adds this attribute to its media type when loading user
>> music in some of the supported formats, and missing it will make media
>> type matching only partially succeed.
>>
>> This will also be useful for WMA/XMA compressed formats.
>>
>> Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
> 
> Can you please describe what exactly it's doing, in terms of specific 
> Media Foundation APIs? As it is I can't tell why you're trying to 
> translate this to and from winegstreamer formats.
> 
> Note also that "block_align" is not used by anything in GStreamer for 
> PCM formats.
> 

WMA/XMA formats caps need a block_align attribute, applications specify 
it in the input media type of the MF transform, and it will need to be 
passed to gstreamer decoder plugin input caps.

Yes, mapping it in this direction is not very useful right now but I 
thought it was better to add the new attribute mapping support all in 
the same change. I can split it if that matters.

FWIW most other attributes will have no use either in GStreamer for 
non-PCM formats, audio/x-wma only has bitrate and block_align for 
instance, does it really matters if we map them nonetheless here and 
even maps them unconditionally to gst caps?
-- 
Rémi Bernon <rbernon at codeweavers.com>