[PATCH v2] shlwapi/tests: Document where SHFormatDateTimeA() crashes for NULL pointers.

[Huw Davies]

On Wed, Sep 01, 2021 at 11:04:26AM +0200, Francois Gouget wrote:
> On Wed, 1 Sep 2021, Huw Davies wrote:
> [...]
> > I don't see the point of this sort of thing.  Why do we care that
> > Windows crashes?  No sane app is ever going to rely on this.
> 
> I disagree with your statement "No sane app is ever going to rely on 
> this".
> 
> For instance GdipGetFamilyName() used to crash when given a NULL output 
> buffer (ad663360fae6). But that changed with Windows 7; 12 years ago. So 
> I'd argue that it's now reasonable for developers to assume 
> GdipGetFamilyName() does not crash in that case.

Sure, there may be specific apps that call specific APIs that'll need
investigation, tests, and fixing, but these will be the exception.

> Also any patch that contains an "if (0) /* crashes */" should have 
> better documentation before it gets applied.

Or better yet, not applied at all IMHO.

> I'm fine with removing the test if you prefer that.

Works for me.

Huw.