[PATCH v2] shlwapi/tests: Document where SHFormatDateTimeA() crashes for NULL pointers.

[Saulius Krasuckas]

Hey folks,

not to derail you, but this triggers me as a former contributor to 
winetest...

On 2021-09-01 12:24, Huw Davies wrote:
> On Wed, Sep 01, 2021 at 11:04:26AM +0200, Francois Gouget wrote:
>> On Wed, 1 Sep 2021, Huw Davies wrote:
>> [...]
>> > I don't see the point of this sort of thing.  Why do we care that
>> > Windows crashes?  No sane app is ever going to rely on this.
   ...
>> Also any patch that contains an "if (0) /* crashes */" should have
>> better documentation before it gets applied.
> 
> Or better yet, not applied at all IMHO.
> 
>> I'm fine with removing the test if you prefer that.
> 
> Works for me.

If you remove it, a guy working on some old app (that misbehaves using 
Wine) will possibly try to add it back. Because one will not know the 
API crashes on newer Windows. But one will know it works in original 
setup eg. on Win 2000 + IE 5.01.

My idea would be to leave two ranges in the comment, something like:

             /* Crashes on: every tested version */
             /* Tested on: Windows XP to Windows 10 20H2 */

And leave it that. Whoever resumes investigation, one could update the 
ranges.

This would cost the suite nothing, IMO. Especially given that there 
still are checks in the suite that dates back to even Win98/WinME. Which 
could carry some real cost in the terms of precision.

My 2€¢,
S.

PS. Nice to see the ML so active:)