[PATCH v2 1/3] winex11.drv: Add GUID_DISPLAY_DEVICE_ARRIVAL interface to display device.

[Paul Gofman]

On 9/6/21 17:45, Zhiyi Zhang wrote:
>
> On 9/6/21 10:40 PM, Paul Gofman wrote:
>> On 9/6/21 17:26, Zhiyi Zhang wrote:
>>> iface_data is not used. You can pass NULL instead.
>> Yeah, thanks, I will resend.
>>
>> Not strictly related, but is there any reason why your Proton patch
>> "winex11.drv: Link display device interfaces" cannot go upstream? Yes, I
>> know the functionality is managed in PnP driver on Windows, but since we
>> don't have one and unlikely to have it in the near future is there
>> anything wrong in making DIGCF_PRESENT flag work this way with display
>> devices? Some games depend on that, and my other patch for
>> D3DKMTOpenAdapterFromDeviceName() implementation is hard to get right
>> without that one working.
>>
> It's because the way DIGCF_PRESENT that is implemented in Proton is incorrect.
> So "winex11.drv: Link display device interfaces" is also not proper.

To summarize, we had a brief conversation with Zhiyi in the chat and
DIGCF_PRESENT is actually implemented upstream for device interfaces, so
the current version of the "Link display device interfaces" patch makes
some sense upstream too. So Zhiyi is going to look into upstreaming that
patch. While my patch for GUID_DISPLAY_DEVICE_ARRIVAL is not actually
much useful with SetupDiGetClassDevsW() not returning any interfaces for
display devices when DIGCF_PRESENT is specified (the only game which I
know depends on that specifies that flag), so I will resend the patch
once that part is upstream.