[PATCH] configure.ac: don't use -Wmisleading-indentation compiler option (GCC11)

Eric Pouech eric.pouech at orange.fr
Tue Sep 28 07:07:30 CDT 2021


after removing the false positives of GCC11 misleading indentation 
warning, a couple of what looks like true positives:


*dinput8/tests/hid.c:4122 (and same construct line 4480 also)*

<<< current code >>>

        if (i == 0 || i == 3) todo_wine_if( i == 0 )
        ok( res == WAIT_TIMEOUT, "WaitForSingleObject succeeded\n" );
        else ok( res == WAIT_OBJECT_0, "WaitForSingleObject failed\n" ); 
ResetEvent( event );

the last ResetEvent( event ) call looks badly placed. could someone 
knowledgeable with the test look into it?


*
**wininet/internet.c:2878*
         if(!lpwhh) {
             SetLastError(ERROR_INTERNET_INCORRECT_HANDLE_TYPE);
             return FALSE;
         } else if(*(ULONG*)lpBuffer & (~(INTERNET_ERROR_MASK_INSERT_CDROM|
                         INTERNET_ERROR_MASK_COMBINED_SEC_CERT|
INTERNET_ERROR_MASK_LOGIN_FAILURE_DISPLAY_ENTITY_BODY))) {
             SetLastError(ERROR_INVALID_PARAMETER);
             ret = FALSE;
         } else if(dwBufferLength != sizeof(ULONG)) {
             SetLastError(ERROR_INTERNET_BAD_OPTION_LENGTH);
             ret = FALSE;
         } else
             TRACE("INTERNET_OPTION_ERROR_MASK: %x\n", *(ULONG*)lpBuffer);
             lpwhh->ErrorMask = *(ULONG*)lpBuffer;

the last assignment (lpwhh->ErrorMask = *(ULONG*)lpBuffer;)
is either badly indented, or misses a block
could someone knowledgeable with the test look into it?


TIA


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20210928/68dd531f/attachment.htm>


More information about the wine-devel mailing list