[PATCH vkd3d 2/5] tests: Allow skipping shader tests if requirements are not met.
Zebediah Figura
zfigura at codeweavers.com
Thu Apr 7 13:02:39 CDT 2022
On 4/7/22 08:07, Henri Verbeet wrote:
> On Wed, 6 Apr 2022 at 23:05, Zebediah Figura <zfigura at codeweavers.com> wrote:
>> + case STATE_REQUIRE:
>> + if (runner->ops->check_requirements && !runner->ops->check_requirements(runner))
>> + goto out;
>> + break;
>> +
> Should we log a message when we skip a test?
I don't think it makes sense to log a message here. My impression,
although it may not be the consensus, is that skips are only useful when
it reveals something about the user's environment that might not be true
of other environments. In the case of a d3d9 shader runner, these tests
will always be skipped.
More information about the wine-devel
mailing list