[PATCH vkd3d 2/5] tests: Allow skipping shader tests if requirements are not met.

[Henri Verbeet]

On Thu, 7 Apr 2022 at 20:02, Zebediah Figura <zfigura at codeweavers.com> wrote:
> On 4/7/22 08:07, Henri Verbeet wrote:
> > On Wed, 6 Apr 2022 at 23:05, Zebediah Figura <zfigura at codeweavers.com> wrote:
> >> +                case STATE_REQUIRE:
> >> +                    if (runner->ops->check_requirements && !runner->ops->check_requirements(runner))
> >> +                        goto out;
> >> +                    break;
> >> +
> > Should we log a message when we skip a test?
>
> I don't think it makes sense to log a message here. My impression,
> although it may not be the consensus, is that skips are only useful when
> it reveals something about the user's environment that might not be true
> of other environments. In the case of a d3d9 shader runner, these tests
> will always be skipped.

In the case where the requirement is shader model 4 in combination
with the d3d9 runner, sure. That wouldn't necessarily be true for a
hypothetical Vulkan or OpenGL runner. Even for d3d9/11/12, it
shouldn't be too hard to imagine caps (e.g. format capabilities) a
particular test may depend on. Either way, I don't feel strongly about
this at this point.