[PATCH 1/3] dlls/d3dx9_36: change read_dword() signature to hide int/long discrepancies

Matteo Bruni matteo.mystral at gmail.com
Fri Apr 15 02:28:57 CDT 2022


On Wed, Apr 13, 2022 at 9:10 AM Eric Pouech <eric.pouech at gmail.com> wrote:
>
> Signed-off-by: Eric Pouech <eric.pouech at gmail.com>
>
> ---
>  dlls/d3dx9_36/effect.c |   98 ++++++++++++++++++++++++------------------------
>  1 file changed, 50 insertions(+), 48 deletions(-)

Thanks for this patch series. Just letting you know that I'm working
on those patches, some parts of d3dx9 REALLY need to be cleaned up and
this is as good an occasion as any to do it.
Hopefully you'll see my version of these patches soon enough but, to
give a rough idea, patch 3/3 introduces a few long integer format
specifiers in printf-like format strings when the variables themselves
have no reason to be long in the first place. In turn, fixing that
properly called for some further cleanup and so on. We'll see how many
patches I'll have in the end...



More information about the wine-devel mailing list