[PATCH 2/2] include: Add windows.media.closedcaptioning.idl file.

[Rémi Bernon]

On 4/22/22 17:14, Zebediah Figura wrote:
> On 4/22/22 04:36, Rémi Bernon wrote:
>> On 4/22/22 09:22, Mohamad Al-Jaf wrote:
>>> Needed by Microsoft Edge.
>>>
>>> Signed-off-by: Mohamad Al-Jaf <mohamadaljaf at gmail.com>
>>> ---
>>> I consider this file very important because people with disabilities
>>> often rely on captioning.
>>
>>
>> Sure, but this file isn't going to do anything on its own. Do you 
>> intend to implement the class too?
> 
> Is that necessary to add WinRT IDLs? We probably want to share these 
> with mingw-w64, so there is value outside of Wine...
> 


I don't think it's necessary, just saying that the file by itself won't 
do anything.

Sharing the header with mingw-w64 is a reason, but I think it's also 
best to have something that actually requires it to build.

I don't think you build Microsoft Edge from source, so if it needs it 
it's probably because it instantiates the class, and it will so need to 
be implemented to do something useful.


I don't mind adding WinRT IDLs for the sake of it, but given the huge 
surface I'm not sure it's really interesting to do it extensively.

Or if we do, maybe we should think of a better way than adding them 
piece by piece or even file by file.

-- 
Rémi Bernon <rbernon at codeweavers.com>