[PATCH 2/2] include: Add windows.media.closedcaptioning.idl file.

Mohamad Al-Jaf mohamadaljaf at gmail.com
Fri Apr 22 21:55:22 CDT 2022


On Fri, Apr 22, 2022 at 5:36 AM Rémi Bernon <rbernon at codeweavers.com> wrote:
> Sure, but this file isn't going to do anything on its own. Do you intend
> to implement the class too?

Hi,

Thanks for the review.

Yes, I plan to implement the class.

> Please follow Wine code style, which is right aligned pointer, and (for
> PATCH 1), snake case parameter identifiers as as far as I can tell the
> casing doesn't matter for WinRT.
> I also think you should add commas on the last enum value, though it's
> not done consistently already, so that adding more values later doesn't
> need to change unrelated lines.

I'll submit a revision for these changes.

--
Kind regards,
Mohamad



More information about the wine-devel mailing list